View Issue Details

IDProjectCategoryView StatusLast Update
0000030Might & Fealty[All Projects] Generalpublic2018-05-31 19:06
ReporterDe-LegroAssigned ToDe-Legro 
PrioritynormalSeverityminorReproducibilityalways
Status assignedResolutionopen 
PlatformN/AOSOS Version
Product Version1.0.4.2 
Target VersionFixed in Version 
Summary0000030: Stable auto build does not respect restrictions
DescriptionStables are only supposed to be built Can only be built in grass- or scrublands. However once a settlements population reaches the autobuild level, it will build them regardless of the terrain of the settlement.
TagsNo tags attached.

Activities

Andrew

2018-05-31 19:06

administrator   bugnote:0000010

Do you have any examples of this, because the code looks like it should be checking this correctly. It checks here: https://github.com/Zanaras/MaFCDR/blob/master/src/BM2/SiteBundle/Command/WorkerBuildingconstructionCommand.php#L86

And that references the code here: https://github.com/Zanaras/MaFCDR/blob/master/src/BM2/SiteBundle/Service/Economy.php#L185

If it returns anything other than true, it sets $canbuild to false, which should make it not select it. Admittedly, the code could definitely be optimized, but it appears to be solid to me.

Issue History

Date Modified Username Field Change
2017-12-19 03:24 De-Legro New Issue
2017-12-19 03:24 De-Legro Status new => assigned
2017-12-19 03:24 De-Legro Assigned To => De-Legro
2018-05-31 19:06 Andrew Note Added: 0000010